#8159 Add exception handling for EncryptionService methods#8179
Closed
wakku9780 wants to merge 4 commits into
Closed
#8159 Add exception handling for EncryptionService methods#8179wakku9780 wants to merge 4 commits into
wakku9780 wants to merge 4 commits into
Conversation
wakku9780
commented
Apr 30, 2026
wakku9780
commented
- Added exception handling when invoking EncryptionService methods
- Prevents crashes due to encryption failures
- Improves system stability and error handling
added 4 commits
April 30, 2026 12:50
Add exception handling when invoking EncryptionService methods nopSolutions#8159
Contributor
|
Hi, @wakku9780! Thank you very much for your help, we've closed the ticket with this commit. But I've also reviewed your changes. You may have noticed that you haven't added exception handling in all places. Also, it's not very correct to set empty values if an error occurs. It's better to do nothing and notify the user about the problem than to hide it. I also noticed some fixes in the tests. I'm not sure if the logic is broken, but even if there really is a problem, it's better to file it in another PR, since this test doesn't address the original issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.